I like it! What I would have done differently: use the original colors, the deep blue color for the window decoration in Windows 98 is quite different from the color you are using. Also I would use a green wallpaper of a shade closer to the default on Windows 95/98, and an icon theme with beige and yellow icons.
I have actually been wanting to do something like this with the old Mac OS 7 “Platinum” theme, modernizing it for Xfce so it looks like the old Mac OS 7 in spirit, but not exactly like Mac OS 7 the way most immitation Platinum themes try to do.
{"data":{"error":"Imgur is temporarily over capacity. Please try again later."},"success":false,"status":403}
Insert “failed successfully” joke here.
Looks good. But I have to ask: why modernize such beautiful theme? The theme in Windows 2000 was even more beautiful, though, but Windows 98 have that nostalgic feeling.
The titlebar is excellent, but the icons don’t feel 98
Yeah I created the title bar but couldn’t find retro but at the same time modern purple icons
looks great, but the icons and the bottom dock don’t really fit in with the win98 style. other than that, i think it’s beautiful!
I would say make the top bar the same or similar to the excellent title bars you’ve already got. Currently feels like they’re from 2 different systems.
EDIT my personal preference is to colour the minimize maximize close buttons.
Other ideas: round the corners just a tiny bit. Make the dock look more like the taskbar maybe. See if there’s examples from “Windows 95 Plus!” Which I think had extra themes.
EDIT 2: it looks great, you’ve done a good job here I like it!