curl https://some-url/ | sh

I see this all over the place nowadays, even in communities that, I would think, should be security conscious. How is that safe? What’s stopping the downloaded script from wiping my home directory? If you use this, how can you feel comfortable?

I understand that we have the same problems with the installed application, even if it was downloaded and installed manually. But I feel the bar for making a mistake in a shell script is much lower than in whatever language the main application is written. Don’t we have something better than “sh” for this? Something with less power to do harm?

  • Zron@lemmy.world
    link
    fedilink
    arrow-up
    16
    ·
    7 days ago

    For security reasons, I review every line of code before it’s executed on my machine.

    Before I die, I hope to take my ‘93 dell optiplex out of its box and finally see what this whole internet thing is about.

  • WolfLink@sh.itjust.works
    link
    fedilink
    arrow-up
    14
    ·
    edit-2
    7 days ago

    It isn’t more dangerous than running a binary downloaded from them by any other means. It isn’t more dangerous than downloaded installer programs common with Windows.

    TBH macOS has had the more secure idea of by default using sandboxes applications downloaded directly without any sort of installer. Linux is starting to head in that direction now with things like Flatpak.

  • emberpunk@lemmy.ml
    link
    fedilink
    English
    arrow-up
    6
    ·
    6 days ago

    You could just read the script file first… Or YOLO trust it like you trust any file downloaded from a relatively safe source… At least you can read a script.

  • Gronk@aussie.zone
    link
    fedilink
    English
    arrow-up
    1
    ·
    6 days ago

    Yeah I hate this stuff too, I usually pipe it into a file figure out what it’s doing and manually install the program from there.

    FWIW I’ve never found anything malicious from these scripts but my internal dialogue starts screaming when I see these in the wild, I don’t want to run some script and not know what it’s touching malicious or not it’s a PITA.

    As a linux user, I like to know what’s happening under the hood as best I can and these scripts go against that

  • zygo_histo_morpheus@programming.dev
    link
    fedilink
    arrow-up
    90
    arrow-down
    4
    ·
    8 days ago

    You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment. Ultimately though, if you are downloading software over the internet you have to place a certain amount of trust in the person your downloading the software from. Even if you’re absolutely sure that the download script doesn’t wipe your home directory, you’re going to have to run the program at some point and it could just as easily wipe your home directory at that point instead.

    • cschreib@programming.devOP
      link
      fedilink
      arrow-up
      7
      ·
      8 days ago

      Indeed, looking at the content of the script before running it is what I do if there is no alternative. But some of these scripts are awfully complex, and manually parsing the odd bash stuff is a pain, when all I want to know is : 1) what URL are you downloading stuff from? 2) where are you going to install the stuff?

      As for running the program, I would trust it more than a random deployment script. People usually place more emphasis on testing the former, not so much the latter.

    • rah@feddit.uk
      link
      fedilink
      English
      arrow-up
      4
      arrow-down
      3
      ·
      edit-2
      8 days ago

      You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment.

      That’s not what projects recommend though. Many recommend piping the output of an HTTP transfer over the public Internet directly into a shell interpreter. Even just

      curl https://... > install.sh; sh install.sh
      

      would be one step up. The absolute minimum recommendation IMHO should be

      curl https://... > install.sh; less install.sh; sh install.sh
      

      but this is still problematic.

      Ultimately, installing software is a labourious process which requires care, attention and the informed use of GPG. It shouldn’t be simplified for convenience.

      Also, FYI, the word “option” implies that I’m somehow restricted to a limited set of options in how I can use my GNU/Linux computer which is not the case.

      • gaylord_fartmaster@lemmy.world
        link
        fedilink
        arrow-up
        6
        arrow-down
        1
        ·
        7 days ago

        Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL, and the people that aren’t doing that don’t care what’s in the script, so why waste their time with it?

        Do you think most users installing software from the AUR are actually reading the pkgbuilds? I’d guess it’s a pretty small percentage that do.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          1
          arrow-down
          2
          ·
          edit-2
          7 days ago

          Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL

          What it accomplishes is providing the instructions (i.e. an easily copy-and-pastable terminal command) for people to do exactly that.

          • gaylord_fartmaster@lemmy.world
            link
            fedilink
            arrow-up
            3
            arrow-down
            1
            ·
            7 days ago

            If you can’t review a bash script before running it without having an unnecessarily complex one-liner provided to you to do so, then it doesn’t matter because you aren’t going to be able to adequately review a bash script anyway.

            • rah@feddit.uk
              link
              fedilink
              English
              arrow-up
              2
              arrow-down
              2
              ·
              7 days ago

              If you can’t review a bash script before running it without having an unnecessarily complex one-liner provided to you

              Providing an easily copy-and-pastable one-liner does not imply that the reader could not themselves write such a one-liner.

              Having the capacity to write one’s own commands doesn’t imply that there is no value in having a command provided.

              unnecessarily complex

              LOL

              • gaylord_fartmaster@lemmy.world
                link
                fedilink
                arrow-up
                2
                arrow-down
                1
                ·
                7 days ago

                I don’t think you realize that if your goal is to have a simple install method anyone can use, even redirecting the output to install.sh like in your examples is enough added complexity to make it not work in some cases. Again, those are not made for people that know bash.

                • rah@feddit.uk
                  link
                  fedilink
                  English
                  arrow-up
                  1
                  arrow-down
                  1
                  ·
                  6 days ago

                  even redirecting the output to install.sh like in your examples is enough added complexity to make it not work in some cases

                  You can’t have any install method that works in all cases.

                  if your goal is to have a simple install method anyone can use

                  Similarly, you can’t have an install method anyone can use.

      • zygo_histo_morpheus@programming.dev
        link
        fedilink
        arrow-up
        2
        arrow-down
        3
        ·
        8 days ago

        I mean if you think that it’s bad for linux culture because you’re teaching newbies the wrong lessons, fair enough.

        My point is that most people can parse that they’re essentially asking you to run some commands at a url, and if you have even a fairly basic grasp of linux it’s easy to do that in whatever way you want. I don’t know if I personally would be any happier if people took the time to lecture me on safety habits, because I can interpret the command for myself. curl https://some-url/ | sh is terse and to the point, and I know not to take it completely literally.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          5
          arrow-down
          1
          ·
          8 days ago

          linux culture

          snigger

          you’re teaching newbies the wrong lessons

          The problem is not that it’s teaching bad lessons, it’s that it’s actually doing bad things.

          most people can parse that they’re essentially asking you to run some commands at a url

          I know not to take it completely literally

          Then it needn’t be written literally.

          I think you’re giving the authors of such installation instructions too much credit. I think they intend people to take it literally. I think this because I’ve argued with many of them.

  • Artyom@lemm.ee
    link
    fedilink
    arrow-up
    41
    ·
    7 days ago

    What’s stopping the downloaded script from wiping my home directory?

    What’s stopping any Makefile, build script, or executable from running rm -rf ~? The correct answer is “nothing”. PPAs are similarly open, things are a little safer if you only use your distro’s default package sources, but it’s always possible that a program will want to be able to delete something in your home directory, so it always has permission.

    Containerized apps are the only way around this, where they get their own home directory.

    • easily3667@lemmus.org
      link
      fedilink
      English
      arrow-up
      6
      arrow-down
      1
      ·
      edit-2
      7 days ago

      Don’t forget your package manager, running someone’s installer as root

      It’s roughly the same state as when windows vista rolled out UAC in 2007 and everything still required admin rights because that’s just how everything worked…but unlike Microsoft, Linux distros never did the thing of splitting off installs into admin vs unprivileged user installers.

      • brian@programming.dev
        link
        fedilink
        arrow-up
        5
        ·
        7 days ago

        plenty of package managers have.

        flatpak doesn’t require any admin to install a new app

        nixos doesn’t run any code at all on your machine for just adding a package assuming it’s already been cached. if it hasn’t been cached it’s run in a sandbox. the cases other package managers use post install configuration scripts for are a different mechanism which possibly has root access depending on what it is.

        • easily3667@lemmus.org
          link
          fedilink
          English
          arrow-up
          1
          ·
          6 days ago

          Gonna ignore nix since they have two users, but flatpak is fair. However flatpak is a sandboxing scheme which is distinct from per-user installs. In many cases it can be the better route but not always. I think the reason it’s popular on Linux is also the dll hell problem.

          • brian@programming.dev
            link
            fedilink
            arrow-up
            1
            ·
            6 days ago

            idk if 2 users is fair, it may just be my circles but I see nixos mentioned more than almost anything else on lemmy/hn/etc in the past couple years

  • esa@discuss.tchncs.de
    link
    fedilink
    arrow-up
    31
    arrow-down
    3
    ·
    8 days ago

    This is simpler than the download, ./configure, make, make install steps we had some decades ago, but not all that different in that you wind up with arbitrary, unmanaged stuff.

    Preferably use the distro native packages, or else their build system if it’s easily available (e.g. AUR in Arch)

  • lemmeBe@sh.itjust.works
    link
    fedilink
    arrow-up
    25
    arrow-down
    3
    ·
    8 days ago

    I think safer approach is to:

    1. Download the script first, review its contents, and then execute.
    2. Ensure the URL uses HTTPS to reduce the risk of man-in-the-middle attacks
  • Undaunted@feddit.org
    link
    fedilink
    arrow-up
    22
    arrow-down
    1
    ·
    8 days ago

    You shouldn’t install software from someone you don’t trust anyway because even if the installation process is save, the software itself can do whatever it has permission to.

    “So if you trust their software, why not their install script?” you might ask. Well, it is detectable on server side, if you download the script or pipe it into a shell. So even if the vendor it trustworthy, there could be a malicious middle man, that gives you the original and harmless script, when you download it, and serves you a malicious one when you pipe it into your shell.

    And I think this is not obvious and very scary.

    • August27th@lemmy.ca
      link
      fedilink
      arrow-up
      7
      ·
      8 days ago

      it is detectable […] server side, if you download the script [vs] pipe it into a shell

      I presume you mean if you download the script in a browser, vs using curl to retrieve it, where presumably you are piping it to a shell. Because yeah, the user agent is going to reveal which tool downloaded it, of course. You can use curl to simply retrieve the file without executing it though.

      Or are you suggesting that curl makes something different in its request to the server for the file, depending on whether it is saving the file to disk vs streaming it to a pipe?

    • FizzyOrange@programming.dev
      link
      fedilink
      arrow-up
      5
      arrow-down
      5
      ·
      edit-2
      8 days ago

      it is detectable on server side, if you download the script or pipe it into a shell

      Irrelevant. This is just an excuse people use to try and win the argument after it is pointed out to them that there’s actually no security issue with curl | bash.

      It’s waaaay easier to hide malicious code in a binary than it is in a Bash script.

      You can still see the “hidden” shell script that is served for Bash - just pipe it through tee and then into Bash.

      Can anyone even find one single instance of that trick ever actually being used in the wild (not as a demo)?

      • Undaunted@feddit.org
        link
        fedilink
        arrow-up
        5
        ·
        8 days ago

        I never tried to win any argument. Hell I was not even aware that I’m participating in one. I just wanted to share the info, that even if the vendor is absolutely trustworthy and even if you validated the script by downloading and looking at it, there’s still another hole that’s not obvious to see.

        Yes it’s unlikely, but again, I never said it were. There are also arguments you can run curl with, to tell it to do the download first and then push it through the pipe afterwards, though I don’t know them by heart now.

        It won’t cost you anything to set those parameters, when you insist to use curl | bash, just in the off chance that someone’s trying to do what I mentioned.

        But I’m also someone who usually validates their downloads with a checksum so maybe I’m just weird. Who knows.